Module:Skills/Artisan: Difference between revisions

Module:Skills/Artisan (view source)

225 bytes added , 29 June 2024

_getHerblorePotionTable: Fix overall potion icons

17,481

edits

@@ Line 170: / Line 170: @@
 			["currencies"] = potion.currencyCosts
 		}, 'N/A', nil, '<br>')
+		-- Prefetch potion items, as these are required for the overall row
+		-- as well as the tier rows
+		local potionItems, lastPotionIdx = {}, 1
+		for j, potionID in ipairs(potion.potionIDs) do
+			potionItems[j] = Items.getItemByID(potionID)
+			lastPotionIdx = j
+		end
 		local row = html:tag('tr')
-		row:tag('td'):wikitext(Icons.Icon({potion.name .. ' IV', type='item', notext=true, nolink=true}))
+		row:tag('td'):wikitext(Icons.Icon({potionItems[lastPotionIdx].name, type='item', notext=true, nolink=true}))
 					 :attr('rowspan', 4):wikitext('[['..potion.name..']]')
 		row:tag('td'):attr('rowspan', 4):wikitext(level)
@@ Line 184: / Line 192: @@
 					 :attr('data-sort-value', Icons.getExpansionID(potion.potionIDs[1]))
-		local tierRows = {}
 		for j, potionID in ipairs(potion.potionIDs) do
-			local rowTxt = {}
+			local tierPot = potionItems[j]
-			local tierPot = Items.getItemByID(potionID)
 			-- First row needs to be added to the main row of the rowspan row.