Module:Sandbox/AuronTest: Difference between revisions

Module:Sandbox/AuronTest (view source)

307 bytes removed , 4 September 2021

m

Remove cloning of item tables as ID is provided in source data

17,105

edits

@@ Line 58: / Line 58: @@
 function p.getItemByID(ID)
-   local result = Shared.clone(ItemData.Items[ID + 1])
+   return ItemData.Items[ID + 1]
-  if result ~= nil then
-    result.id = ID
-  end
-  return result
 end
@@ Line 72: / Line 68: @@
    for i, item in pairs(ItemData.Items) do
      local itemName = string.gsub(item.name, '#', '')
-     if(name == itemName) then
+     if (name == itemName) then return item end
-      result = Shared.clone(item)
-      --Make sure every item has an id, and account for Lua being 1-index
-      result.id = i - 1
-      break
-    end
    end
-  return result
 end
@@ Line 86: / Line 76: @@
    for i, item in pairs(ItemData.Items) do
      if checkFunc(item) then
-      local newItem = Shared.clone(item)
+       table.insert(result, item)
-      newItem.id = i - 1
-       table.insert(result, newItem)
      end
    end